Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SemanticAnalysisVisitor: detect if several solve blocks are given #1094

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

alkino
Copy link
Member

@alkino alkino commented Nov 9, 2023

No description provided.

@alkino alkino linked an issue Nov 9, 2023 that may be closed by this pull request
@alkino alkino force-pushed the cornu/fail_if_several_solve_blocks branch from c00553b to 7e91888 Compare November 9, 2023 09:29
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (36199d0) 88.64% compared to head (175f89d) 88.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1094      +/-   ##
==========================================
+ Coverage   88.64%   88.67%   +0.02%     
==========================================
  Files         169      169              
  Lines       12500    12525      +25     
==========================================
+ Hits        11081    11106      +25     
  Misses       1419     1419              
Files Coverage Δ
src/visitors/semantic_analysis_visitor.cpp 91.01% <100.00%> (+1.26%) ⬆️
src/visitors/semantic_analysis_visitor.hpp 100.00% <ø> (ø)
test/unit/visitor/semantic_analysis.cpp 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #168558 (:white_check_mark:) have been uploaded here!

Status and direct links:

Copy link
Contributor

@ohm314 ohm314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me

@ohm314 ohm314 merged commit f57d0d7 into master Nov 16, 2023
18 checks passed
@ohm314 ohm314 deleted the cornu/fail_if_several_solve_blocks branch November 16, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplication of SOLVE leads to error or hang
3 participants